Tj Jacobs

[TII-18456] create tag from CheckoutPatch branch
[TII-18456] wrong tag
[TII-18456] create tag from CheckoutPatch branch
[TII-18494] create tag from CheckoutPatch
  • More
  • ACT-12
  • finished reviewing
Verified

Verified

Verified

Verified

Discussed and agreed

Discussed and agreed

[TII-18335] tag the branch February2015 for v.1.65.00.01
[TII-18335] tag the branch February2015 for v.1.65.00.01
  • More
  • ACT-11
  • commented on review
Approved Design http://apgwiki.genpt.net/Configuration_Management/APGCM_Internal_Projects/2014_Projects/Create_Branch_-_Chris Jenkins Job http://auapgpdcibapp02/jenkins/job/create_branch_test/
Still two occurrences in the code, in these two sections The build was successful, updating the buildmetrics table with final update The build was successful, updating the configtodo table with fin...

Still two occurrences in the code, in these two sections
The build was successful, updating the buildmetrics table with final update
The build was successful, updating the configtodo table with final update

Verified

Verified

Verified

Verified

Design 1.5 Your design references a parameter called FIX_VERSION. That parameter is not in your code. I think you have replaced FIX_VERSION, that agreed on standard, with this BUILD_VERSION paramet...

Design 1.5
Your design references a parameter called FIX_VERSION. That parameter is not in your code. I think you have replaced FIX_VERSION, that agreed on standard, with this BUILD_VERSION parameter. It occurs 24 times in you code and needs to be updated to reflect your design.

Design 1.6 The JQL in your design shows, status = Staging, but your code is using, status != Closed. Update your code to reflect the design.

Design 1.6
The JQL in your design shows, status = Staging, but your code is using, status != Closed. Update your code to reflect the design.

Design 1.13 Your design has a parameter called MYSQL_HOST. It is not present in your code, but appears to have been replaces with, MYSQLHOST. MYSQLHOST appears 20 times in your code and should be u...

Design 1.13
Your design has a parameter called MYSQL_HOST. It is not present in your code, but appears to have been replaces with, MYSQLHOST. MYSQLHOST appears 20 times in your code and should be updated to reflect your design.

Design 7.3 Your design references a buildMetricID that is similar tot he above NewBuildmetricsEntry. Your design has more database columns that are in a different order than they appear here in you...

Design 7.3
Your design references a buildMetricID that is similar tot he above NewBuildmetricsEntry. Your design has more database columns that are in a different order than they appear here in your code.

Design #10 I think this is where you code would be looking to figure out which working copy folder is checked out and making SVN adjustments to ceck out the correct code.

Design #10
I think this is where you code would be looking to figure out which working copy folder is checked out and making SVN adjustments to ceck out the correct code.

Jenkins http://cmtools.genpt.net/jenkins/view/Release%20Candidate%20Jobs/job/RC_NAPAOnlineSupport/ Build Automation: NAPAOnlineSupport Design http://apgwiki.genpt.net/Configuration_Management/APGC...
OBJECTIVES verify that code meets GPC development standards verify that code meets industry development standards for the programming language used verify that the code does not create any security...

OBJECTIVES
verify that code meets GPC development standards
verify that code meets industry development standards for the programming language used
verify that the code does not create any security issues
verify that the code meets standards set for PCI compliance

Confirmed

Confirmed

Confirmed

Confirmed

Confirmed

Confirmed

  • More
  • NACM-1
  • finished reviewing
Code has been reviewed and three findings have been documented.

Code has been reviewed and three findings have been documented.

Please remove the comments from here, and add each comment to the top of the code that executes. This will help clear up what the code is operating on.

Please remove the comments from here, and add each comment to the top of the code that executes. This will help clear up what the code is operating on.

There are 20 occurrences of MYSQLHOST in the code. The approved standard name is MYSQL_HOST. Update the remainder of the values.

There are 20 occurrences of MYSQLHOST in the code. The approved standard name is MYSQL_HOST. Update the remainder of the values.

The Design is documented to say, under section 1.6 JQL: project = NACM and issuetype = "Build Request" and status = "Staging" Need to review the Design and update to the approved search

The Design is documented to say, under section 1.6
JQL: project = NACM and issuetype = "Build Request" and status = "Staging"

Need to review the Design and update to the approved search