SilverJRunner

  • More
  • SJR-1
  • finished reviewing
  • More
  • SJR-1
  • finished reviewing
This profile is missing the code <build>...</build> block that ftp the build artifact to the server. Need to get that block out of the silver module pom from the original RemoteAccess project and a...

This profile is missing the code <build>...</build> block that ftp the build artifact to the server. Need to get that block out of the silver module pom from the original RemoteAccess project and add to here.

Line 147 is extra and should be removed

Line 147 is extra and should be removed

The version need to match what Remote Access is using

The version need to match what Remote Access is using

Line 22-28: Please add the missing groupId for this block. Please also change the version to be same as what RemoteAccess is using.

Line 22-28: Please add the missing groupId for this block. Please also change the version to be same as what RemoteAccess is using.

Please replace archive.server.ftp.build.dir with deploy.server.ftp.build.dir

Please replace archive.server.ftp.build.dir with deploy.server.ftp.build.dir

Please replace archive.server.ftp.dir with deploy.server.ftp.dir

Please replace archive.server.ftp.dir with deploy.server.ftp.dir

Please replace archive.server.prompt with deploy.server.prompt

Please replace archive.server.prompt with deploy.server.prompt

Please replace archive.server.ssh.timeout with deploy.server.timeout Please move this line below the server prompt line

Please replace archive.server.ssh.timeout with deploy.server.timeout
Please move this line below the server prompt line

Please replace archive.server.root.pass with deploy.server.root.pass

Please replace archive.server.root.pass with deploy.server.root.pass

Please replace archive.server.ftp.pass with deploy.server.pass

Please replace archive.server.ftp.pass with deploy.server.pass

Please replace archive.server.ftp.user with deploy.server.user

Please replace archive.server.ftp.user with deploy.server.user

Please replace archive.server.ip with deploy.server.ip The ip address should not be checked in and only passed in at build time.

Please replace archive.server.ip with deploy.server.ip
The ip address should not be checked in and only passed in at build time.

The plain password should not be checked in and only passed in at build time.

The plain password should not be checked in and only passed in at build time.

The archiva url should not be checked in and only passed in at build time.

The archiva url should not be checked in and only passed in at build time.

Please add a block for the missing HOTDEPLOY and DEPLOY_ARCHIVE profiles. The DEPLOY_ARCHIVE profile block also needs to include the code to ftp the jar build artifact to the Build Archive server a...

Please add a block for the missing HOTDEPLOY and DEPLOY_ARCHIVE profiles. The DEPLOY_ARCHIVE profile block also needs to include the code to ftp the jar build artifact to the Build Archive server as well as all the needed dependencies for the maven-antrun-plugin plugin. You can refer to the MCW project for details.

Line 182-217: This block is related to adding a version to the ACT database so it is not needed and should be removed.

Line 182-217: This block is related to adding a version to the ACT database so it is not needed and should be removed.

Line 140-175: This block is related to adding a version to the ACT database so it is not needed and should be removed.

Line 140-175: This block is related to adding a version to the ACT database so it is not needed and should be removed.

Since we are no longer using Bugzilla please change it to Jira

Since we are no longer using Bugzilla please change it to Jira

Please fix the indentation of this line.

Please fix the indentation of this line.

Version number should be between groupId and artifactId

Version number should be between groupId and artifactId

Please fix the indentation of this line.

Please fix the indentation of this line.

This line is not required and the code will work without it.

This line is not required and the code will work without it.

  • More
  • SJR-1
  • started review
SilverJRunner(Stand Alone)/RemoteAccess
SilverJRunner(Stand Alone)/RemoteAccess