NAPA_Xpress

NAPA_Xpress

Activity on this page:
Friday 24 Nov 2017
1:53 am

Mrinalini Kanthadai (deleted user)

1:47 am

Mohammed Ismail (deleted user)

Friday 29 Sep 2017
2:23 am

Vedamoorthy Anbazhakan (deleted user)

[NXP-682] - Update Sales Order JIA cHANGES
[NXP-682] - Update Sales Order JIA cHANGES
2:23 am

Vedamoorthy Anbazhakan (deleted user)

  • More
  • NXP-21
  • submitted for moderator approval
2:21 am

Vedamoorthy Anbazhakan (deleted user)

[NXP-681] - JIA Changes for Create PO , Update PO (NXP-388) and Update SO (NXP-683) to TAMS. Also NXP...
[NXP-681] - JIA Changes for Create PO , Update PO (NXP-388) and Update SO (NXP-683) to TAMS. Also NXP...
2:21 am

Vedamoorthy Anbazhakan (deleted user)

  • More
  • NXP-20
  • submitted for moderator approval
2:19 am

Vedamoorthy Anbazhakan (deleted user)

[NXP-681] - JIA Changes for Create PO , Update PO (NXP-388) and Update SO (NXP-683) to TAMS. Also NXP...
[NXP-681] - JIA Changes for Create PO , Update PO (NXP-388) and Update SO (NXP-683) to TAMS. Also NXP...
2:19 am

Vedamoorthy Anbazhakan (deleted user)

  • More
  • NXP-18
  • submitted for moderator approval
Thursday 28 Sep 2017
9:27 am

Vedamoorthy Anbazhakan (deleted user)

[NXP-674], [NXP-675] JIA changes stories committed.
[NXP-674], [NXP-675] JIA changes stories committed.
9:27 am

Vedamoorthy Anbazhakan (deleted user)

  • More
  • NXP-17
  • submitted for moderator approval
9:25 am

Vedamoorthy Anbazhakan (deleted user)

[NXP-666], [NXP-674], [NXP-675] JIA changes stories committed.
[NXP-666], [NXP-674], [NXP-675] JIA changes stories committed.
9:25 am

Vedamoorthy Anbazhakan (deleted user)

  • More
  • NXP-16
  • submitted for moderator approval
Wednesday 27 Sep 2017
3:49 am

Mohammed Ismail (deleted user)

  • More
  • NXP-14
  • finished reviewing
3:48 am

Mohammed Ismail (deleted user)

Please see, if both of these "if" conditions are making sense here

Please see, if both of these "if" conditions are making sense here

3:44 am

Mohammed Ismail (deleted user)

  • More
  • NXP-13
  • finished reviewing
3:42 am

Mohammed Ismail (deleted user)

Please add string constants as applicable. (e.g. PART_NUMBER)

Please add string constants as applicable. (e.g. PART_NUMBER)

3:38 am

Mohammed Ismail (deleted user)

What is the guarantee of getting these elements (0), (1), (2), if they are as per JIA, please ignore my comment and add a line of comment in the code to explain the same. If not this is a potential...

What is the guarantee of getting these elements (0), (1), (2), if they are as per JIA, please ignore my comment and add a line of comment in the code to explain the same. If not this is a potential NPE place.

3:37 am

Mohammed Ismail (deleted user)

There is so much of business logic happening inside the following for loop, which does not use the iterated element "consignmentEntryModel". Please see and revisit, if the value assignments require...

There is so much of business logic happening inside the following for loop, which does not use the iterated element "consignmentEntryModel". Please see and revisit, if the value assignments required to be with-in for loop (e.g. pickedData = listEventIdentifierPickWsDTO.get(2).getFields().getField().get(0).getValue()

for (ConsignmentEntryModel consignmentEntryModel : setConsignmentEntryModel)

Tuesday 26 Sep 2017
10:52 am

Mohammed Ismail (deleted user)

  • More
  • NXP-15
  • finished reviewing
10:51 am

Mohammed Ismail (deleted user)

Please remove commented code, always can get it from history

Please remove commented code, always can get it from history

10:48 am

Mohammed Ismail (deleted user)

Please use individual braces to segregate, if needed use multiple if statements

Please use individual braces to segregate, if needed use multiple if statements

10:44 am

Mohammed Ismail (deleted user)

  • More
  • NXP-12
  • finished reviewing
10:44 am

Mohammed Ismail (deleted user)

Kindly revisit the logic of looping through elements, too much of if else statements

Kindly revisit the logic of looping through elements, too much of if else statements

10:35 am

Mohammed Ismail (deleted user)

  • More
  • NXP-10
  • finished reviewing
10:35 am

Mohammed Ismail (deleted user)

Use a string constant at class level

Use a string constant at class level

10:18 am

Mohammed Ismail (deleted user)

Please revisit if a dummy method can be introduced to calculate the date from a date returned by mock IC service

Please revisit if a dummy method can be introduced to calculate the date from a date returned by mock IC service

10:08 am

Mohammed Ismail (deleted user)

  • More
  • NXP-8
  • finished reviewing
9:46 am

Mohammed Ismail (deleted user)

This line will always return null. Kindly revisit the intended logic. Provide required comments

This line will always return null. Kindly revisit the intended logic. Provide required comments

9:43 am

Mohammed Ismail (deleted user)

Avoid DTO, use a data bean. Try segregating the DTO from front-end logic

Avoid DTO, use a data bean. Try segregating the DTO from front-end logic

9:32 am

Mohammed Ismail (deleted user)

Please change from getModelService().saveAll(); getModelService().save(customerInfo); getModelService().save(cartModel); to getModelService().saveAll(customerInfo, cartModel);

Please change from

getModelService().saveAll();
getModelService().save(customerInfo);
getModelService().save(cartModel);

to

getModelService().saveAll(customerInfo, cartModel);