PulseUI/src/main/java/com/napa/pulse/dao/impl

ReviewDAOImpl.java

Clone Tools

Stats

Commits this week: 1
Total Committers: 28
Last Commit: 04 Jul
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 26 May 2020
10:24 am

Raj Babu (deleted user) and David Hannan (deleted user)

8:57 am

Eliott Nicholson (deleted user)

Yes, because this rule is only for Override id 1 which is the rule they want for SKUs in the PRODUCT_OVERRIDE table to have a block order = Y. If we have other rules based off this table, we can ju...

Yes, because this rule is only for Override id 1 which is the rule they want for SKUs in the PRODUCT_OVERRIDE table to have a block order = Y. If we have other rules based off this table, we can just have a similar rule, with a different ID.

8:51 am

Raj Babu (deleted user)

Limit to override_id = 1?

Limit to override_id = 1?

8:50 am

Raj Babu (deleted user)

Limit to override_id = 1?

Limit to override_id = 1?

8:50 am

Raj Babu (deleted user)

Are you limiting this to override_id = 1?

Are you limiting this to override_id = 1?

8:44 am

Raj Babu (deleted user)

Sames as override.sql. Please remove PULSEUI if the table needs to be created in both US and UAP

Sames as override.sql. Please remove PULSEUI if the table needs to be created in both US and UAP

8:42 am

Raj Babu (deleted user)

Remove PULSEUI if intended for both US and UAP

Remove PULSEUI if intended for both US and UAP

8:42 am

Raj Babu (deleted user)

Remove PULSEUI if intended for both US and UAP

Remove PULSEUI if intended for both US and UAP

8:41 am

Raj Babu (deleted user)

Remove prefix PULSEUI if intended for both US and UAP

Remove prefix PULSEUI if intended for both US and UAP

12:27 am

Eliott Nicholson (deleted user)

12:26 am

Eliott Nicholson (deleted user)

[PUL-7159] - Product Override addition and small bug fixes for [PUL-7157] and [PUL-7160]
[PUL-7159] - Product Override addition and small bug fixes for [PUL-7157] and [PUL-7160]
12:23 am

Eliott Nicholson (deleted user)

12:22 am

Eliott Nicholson (deleted user)

[PUL-7159] - Product Override addition and small bug fixes for [PUL-7157] and [PUL-7160]
[PUL-7159] - Product Override addition and small bug fixes for [PUL-7157] and [PUL-7160]
12:21 am

Eliott Nicholson (deleted user)

Modified BR's to block order based on new product_override and override table. *Then modified fleets and sim parts to not add products from product_override table since that could occur. *I am le...

Modified BR's to block order based on new product_override and override table.

  • Then modified fleets and sim parts to not add products from product_override table since that could occur.
  • I am less familiar with add sim parts and add fleets sp's, so let me know if any changes are needed.


Lastly, I went ahead and pushed the change for the subquery returning more parts than it should noted on this jira: PUL-7157
Also pushed the change that Hannan and I were looking at regarding the site queue not clearing out in some cases: PUL-7160

12:18 am

Eliott Nicholson (deleted user)

[PUL-7159] - Product Override addition and small bug fixes for [PUL-7157] and [PUL-7160]
[PUL-7159] - Product Override addition and small bug fixes for [PUL-7157] and [PUL-7160]
Wednesday 06 May 2020
7:07 am

David Hannan (deleted user)

7:06 am

David Hannan (deleted user)

Monday 04 May 2020
3:40 pm

Matthew Giannelli (deleted user)

[PUL-7118] Added site copy functionality for New Numbers
[PUL-7118] Added site copy functionality for New Numbers
3:40 pm

Matthew Giannelli (deleted user)

Refactored based on changes in ParametersDAOImpl. Validated that the new numbers hierarchies load as expected.

Refactored based on changes in ParametersDAOImpl. Validated that the new numbers hierarchies load as expected.

3:39 pm

Matthew Giannelli (deleted user)

Changed return type so we can easily reuse this in the site copy without having to convert from a Map. The UI code was refactored to handle this change.

Changed return type so we can easily reuse this in the site copy without having to convert from a Map. The UI code was refactored to handle this change.

Thursday 19 Mar 2020
9:47 am

Matthew Giannelli (deleted user)

9:47 am

Matthew Giannelli (deleted user)

Ah, that makes sense.

Ah, that makes sense.

9:40 am

Raj Babu (deleted user) and Matthew Giannelli (deleted user)

9:34 am

Raj Babu (deleted user)

CASE.. END is SQL standard. We have to start using SQL standard statements, if and when we move to a different DB. DECODE is an ORACLE function

CASE.. END is SQL standard. We have to start using SQL standard statements, if and when we move to a different DB. DECODE is an ORACLE function

9:09 am

Eliott Nicholson (deleted user)

Yea, I could have done a decode. I think it will get a little more complex next sprint though, which will likely need cases, so that is part of the reason I left it as a case for now.

Yea, I could have done a decode. I think it will get a little more complex next sprint though, which will likely need cases, so that is part of the reason I left it as a case for now.

9:08 am

Matthew Giannelli (deleted user)

[PUL-6994] New Numbers: Review Page: Icon & Quick Filter - UI
[PUL-6994] New Numbers: Review Page: Icon & Quick Filter - UI
8:22 am

Matthew Giannelli (deleted user)

Perhaps cleaner to use a decode here? decode(REASON_ID, 0, 1, 0) Not a blocker though.

Perhaps cleaner to use a decode here?

decode(REASON_ID, 0, 1, 0)


Not a blocker though.

Wednesday 18 Mar 2020
3:32 pm

David Hannan (deleted user)

3:17 pm

Eliott Nicholson (deleted user)

[PUL-6994] New Numbers: Review Page: Icon & Quick Filter - UI
[PUL-6994] New Numbers: Review Page: Icon & Quick Filter - UI
Friday 07 Feb 2020
9:12 am

Matthew Giannelli (deleted user)