Dashboard

  • More
  • ESB-135
  • summarized and closed
Showing Manojna how to do a file level comment.

Showing Manojna how to do a file level comment.

Showing Manojna how to do an inline comment.

Showing Manojna how to do an inline comment.

[ESB-28741] Adding Unit Tests For ServiceReplayHandler
[ESB-28741] Adding Unit Tests For ServiceReplayHandler
How are we guaranteed that the first paid found will be the fastest?

How are we guaranteed that the first paid found will be the fastest?

Will this condition of "the paid delivery is the best delivery for this site" still be checked? It appears that we are only doing this for when the the site does not have a free delivery. If that i...

Will this condition of "the paid delivery is the best delivery for this site" still be checked? It appears that we are only doing this for when the the site does not have a free delivery. If that is true, we should remove this comment.

This is a good opportunity to create a separate method and a unit test for it. The method should be outside of this class, probably some kind of Visitor pattern that could take in the Delivery list...

This is a good opportunity to create a separate method and a unit test for it. The method should be outside of this class, probably some kind of Visitor pattern that could take in the Delivery list and return the quickest free delivery. If it is null, then it can be assumed that there is no quickest free delivery.

[ESB-29393] - Fix for Blue bucket not populating since Paid option was picked up.
[ESB-29393] - Fix for Blue bucket not populating since Paid option was picked up.
  • More
  • ESB-133
  • summarized and closed
Just a couple of more updates.

Just a couple of more updates.

Close connection in try/finally.

Close connection in try/finally.

Remove commented code.

Remove commented code.

Close connection in try/finally.

Close connection in try/finally.

Remove commented code.

Remove commented code.

Use Logger.error(e.getMessage(), e) so that the Exceptions stack trace prints to the log.

Use Logger.error(e.getMessage(), e) so that the Exceptions stack trace prints to the log.

ESB-26722: [CERTIFICATES] Automate Refresh Certificates for Java Services
ESB-26722: [CERTIFICATES] Automate Refresh Certificates for Java Services
ESB-28741: Add Unit Tests for ReplayHandler
ESB-28741: Add Unit Tests for ReplayHandler
[ESB-28799] - Reverted code changes to map quantity from site.Quantity.getAvailable instead of...
[ESB-28799] - Reverted code changes to map quantity from site.Quantity.getAvailable instead of...
[ESB-28799] - Made code changes to map quantity from site.Quantity.getAvailable instead of...
[ESB-28799] - Made code changes to map quantity from site.Quantity.getAvailable instead of...
The changes will work. I created a JIRA for refactoring the code at a later time.

The changes will work. I created a JIRA for refactoring the code at a later time.

It would be best to refactor the setting of availableQty to 1 method.

It would be best to refactor the setting of availableQty to 1 method.