ESB/branches/APG_ES_Product/Java/nsight-product-availability/src/.../genpt/nsight/v1/service/impl

Site2ZipDeliveryEstimateServiceImpl.java

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 08 Jan 22
Commits this week: 0
Total Lines of Code (LoC): 0
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 10 Jan 2022
2:46 pm

Tracy Martin (deleted user)

ESB-27573: [PRODUCT] Change Get Parts Services from Local One to Local Quorum
ESB-27573: [PRODUCT] Change Get Parts Services from Local One to Local Quorum
Saturday 08 Jan 2022
10:51 am

Robin Mathew

ESB-27573 - change consistency level to local quorum

Options
    • ?
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 13 more files in changeset.
Wednesday 01 Sep 2021
8:42 am

Robin Mathew

ESB-24471 - Initial Changes for NOL FreepaidV4 and handle different delivery estimates for each cutoff time from the free delivery by day table

Options
    • ?
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 65 more files in changeset.
Friday 18 Dec 2020
12:44 pm

Tracy Martin (deleted user)

12:44 pm

Tracy Martin (deleted user)

  • More
  • ESB-24
  • finished reviewing
Tuesday 20 Oct 2020
3:59 pm

Tracy Martin (deleted user)

it is confusing to have a variable named V2 that is actually the V3 class .

it is confusing to have a variable named V2 that is actually the V3 class .

3:51 pm

Tracy Martin (deleted user)

This is a good candidate for an Enum. It could go in the model package.

This is a good candidate for an Enum. It could go in the model package.

3:51 pm

Tracy Martin (deleted user)

This is a good candidate for an Enum. It could go in the model package.

This is a good candidate for an Enum. It could go in the model package.

3:43 pm

Tracy Martin (deleted user)

It would be more efficient to have 1 filter statement and 1 collect. For instance, .filter(s -> s.getDeliveryServiceType().compareToIgnoreCase(deliveryServiceType) == 0 && s.getDayOfTheWeek().compa...

It would be more efficient to have 1 filter statement and 1 collect. For instance,
.filter(s -> s.getDeliveryServiceType().compareToIgnoreCase(deliveryServiceType) == 0
&& s.getDayOfTheWeek().compareToIgnoreCase(dayOfWeek) == 0)
.collect(Collectors.toList());

3:40 pm

Tracy Martin (deleted user)

Can we rename the name of the table to site_delivery_lead_time? Usually, table names are not plural. Could we change the order of the clustering key to delivery_service_type, day_of_week, reason_co...

Can we rename the name of the table to site_delivery_lead_time? Usually, table names are not plural.
Could we change the order of the clustering key to delivery_service_type, day_of_week, reason_code? I think this will be used more than the other way around during triage.

Monday 19 Oct 2020
2:24 pm

Tracy Martin (deleted user)

In this class we are still using v1 SplunkLogger.

In this class we are still using v1 SplunkLogger.

2:17 pm

Tracy Martin (deleted user)

I see in some classes that we are still using v2 SplunkLogger, but in other classes, we are using v3.SplunkLogger. Do we need to have a v3? What's the difference?

I see in some classes that we are still using v2 SplunkLogger, but in other classes, we are using v3.SplunkLogger. Do we need to have a v3? What's the difference?

2:08 pm

Tracy Martin (deleted user)

We should log the error if there is an exception with the stack trace.

We should log the error if there is an exception with the stack trace.

12:57 pm

Tracy Martin (deleted user)

It is confusing to have the variable name as v2 and the class as v3.

It is confusing to have the variable name as v2 and the class as v3.

12:57 pm

Tracy Martin (deleted user)

It is confusing to have the variable name as v2 and the class as v3.

It is confusing to have the variable name as v2 and the class as v3.

12:40 pm

Tracy Martin (deleted user)

Should this be ProductAvailabilityControllerV3?

Should this be ProductAvailabilityControllerV3?

12:38 pm

Tracy Martin (deleted user)

Should this be ProductAvailabilityControllerV3?

Should this be ProductAvailabilityControllerV3?

12:31 pm

Tracy Martin (deleted user)

ESB-17639: [NSIGHT] Get Parts Changes to incorporate Lead Time Data
ESB-17639: [NSIGHT] Get Parts Changes to incorporate Lead Time Data
Wednesday 14 Oct 2020
3:54 pm

Robin Mathew

ESB-17639 - implemented lead times in getparts V3

Options
    • -1
    • +1
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 46 more files in changeset.
Saturday 22 Feb 2020
10:15 am

Robin Mathew

ESB-11657 Fix wrong bucket issue with Aggregate by relationship

Options
    • -1
    • +1
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 7 more files in changeset.
Friday 08 Mar 2019
3:04 pm

Bharadwaj_Nelabhotia@genpt.com

ESB-5580 implemented Inventory verification service

Options
    • -2
    • +8
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 14 more files in changeset.
Thursday 13 Dec 2018
11:50 am

Robin Mathew

ESB-4929 Use timezone data to calculate the quickest delivery method

Options
    • -1
    • +1
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 3 more files in changeset.
Tuesday 11 Dec 2018
6:16 pm

Robin Mathew

ESB-4929 Added calcuation for date for times across UTC midnight

Options
    • -4
    • +18
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 9 more files in changeset.
Tuesday 06 Nov 2018
10:04 am

Robin Mathew

ESB-4130 Initial check in of Getparts microservice code

Options
    • -0
    • +194
    ./Site2ZipDeliveryEstimateServiceImpl.java
  2. … 168 more files in changeset.