Comment Search

Along with the previous change I've requested you will now need to add back the instructions to select the Version(s) from the list available before clicking the Run Report button.

since you are dynamically populating the contents of the list box above, these 3 lines are no longer needed. These are used to populate the list box from a data query which you are no longer doing.

If they did not select a Version, we want to send them a message telling them they have to fill select one to run the report (the message is already there a few lines below this). This particular if section needs to be removed and only leave the other 2 in the if else block.

you removed a column but didn't change all rows to now only have 3 columns

this error message needs to be updated to say Issue instead of defect and state that it should be letters, numbers, and a single dash instead of just numbers only.

you removed a column but didn't change all rows to now only have 3 columns

change the word Defect to Issue

since you are dynamically populating the contents of the list box above, these 3 lines are no longer needed. These are used to populate the list box from a data query which you are no longer doing.

these credentials need to be stored in the web.config file and parameterized into this function

since you are dynamically populating the contents of the list box above, these 3 lines are no longer needed. These are used to populate the list box from a data query which you are no longer doing.

since we are now requiring all Issues in a build to have that build number in the FixVersion field, this should now only be a single select box.

don't declare this on one line and enter the default value on a different one. Please put this into a single line.

change the word "Defect" to "Issue"

it is a bad practice to define a variable at the global level unless it is a constant or something of that nature. Since you are only using this variable in the function BindData you should instead declare it within that function. This avoids having scope problems with the variable.

this is only going to show the first fixversion assigned to this issue which isn't even going to be the version selected in all cases. This needs to show a comma separated list of all fixversion values assigned to the issue

unless there is a reason, you shouldn't unnecessarily assign a variable into another variable that you are then just going to use the value of. Just use the jira_issue.key.ToString(); in all of the places you are now using the string bug_id

since you are dynamically populating the contents of the list box above, these 3 lines are no longer needed. These are used to populate the list box from a data query which you are no longer doing.

please make the Text and the Value for each li set to jira_project.name. This way you don't have to make a new soap call to get the name when the user pushes the button to run the report. it will just pull it from the selected list item.

change the colspan to 2

the search results coming back from Jira using this query are not what we expect. Please rework this report to first get a list of distinct Issue IDs from the CMReports Subversion database and then check that list (via a loop) against Jira to see if that Issue ID's fixVersion(s) are set to the one selected by the users

please make the Text and the Value for each li set to jira_project.name. This way you don't have to make a new soap call to get the name when the user pushes the button to run the report. it will just pull it from the selected list item.

since you are dynamically populating the contents of the list box above, these 3 lines are no longer needed. These are used to populate the list box from a data query which you are no longer doing.

this is a debugging line that needs to be removed

change the word Defects to Issues

Reviewed