PUL-361 [PUL-6992] - Support for New Number inclusions in Standard Sessions

closed on 16 Mar 20

[PUL-6992] - Support for New Number inclusions in Standard Sessions

Author

Reviewers

Details
Objectives
General Comments 0
Number of files included: 8

PulseUI 0
- Folder src/main 0
  - Folder java/com/napa/pulse 0
    - Folder controller/rest 0
      - File SessionRestController.java 0 Remove
    - Folder dao 0
      - Folder impl 0
        
        File SessionDAOImpl.java 2 Remove
      - Folder interfaces 0
        
        File SessionDAO.java 0 Remove
    - Folder dto 0
      - File SessionPreferencesDTO.java 0 Remove
    - Folder service 0
      - Folder impl 0
        
        File SessionServiceImpl.java 0 Remove
      - Folder interfaces 0
        
        File SessionService.java 0 Remove
  - Folder webapp/app/src 0
    - Folder repositories 0
      - File sessionRepo.js 0 Remove
    - Folder session/preferences 0
      - File sessionPreferenceCtrl.js 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Eliott Nicholson (deleted user)	Author	7m	1	Was going to give it a little time... I rushed the SP, my...
David Hannan (deleted user)	Reviewer - Complete	6m
Raj Babu (deleted user)	Reviewer - 0% reviewed
Matthew Giannelli (deleted user)	Reviewer - Complete	19m	1	Should this be changed back to CREATE_NEW_SESSION now, or...
Yong Wang (deleted user)	Reviewer - 0% reviewed
Total		32m	2

Linked Issue:
PUL-6992

#permalink

Objectives

PUL-6992 - Support for New Number inclusions in Standard Sessions

Added SP for including new numbers: CREATE_NEW_SESSION_ELIOTT (will drop Eliott once this is reviewed)
Added Java code to support New Number inclusion in session creation and session review preferences.
Made frontend changes to pass includeNewNumbers through to Service --> DB.

Review this carefully... I don't frontend.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

PUL-361

[PUL-6992] - Support for New Number inclusions in Standard Sessions

PUL-361 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Create issue

Log time against

[PUL-6992] - Support for New Number inclusions in Standard Sessions

PUL-361 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Create issue

Log time against