PUL-346 [PUL-6930] Reworked aco_session_hierarchy updates

closed on 05 Mar 20

[PUL-6930] Reworked aco_session_hierarchy updates

Author

Reviewers

Details
Objectives
General Comments 0
Number of files included: 9

PulseUI 0
- Folder src 0
  - Folder main/java/com/napa/pulse 0
    - Folder dao 0
      - Folder impl 0
        
        File AcoDAOImpl.java 2 Remove
        
        File SessionDAOImpl.java 1 Remove
      - Folder interfaces 0
        
        File AcoDAO.java 0 Remove
        
        File SessionDAO.java 0 Remove
    - Folder service 0
      - Folder impl 0
        
        File AcoServiceImpl.java 0 Remove
        
        File SessionServiceImpl.java 0 Remove
      - Folder interfaces 0
        
        File AcoService.java 0 Remove
        
        File SessionService.java 0 Remove
  - Folder test/groovy/com/napa/pulse/dao/impl 0
    - File AcoDaoImplTest.groovy 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Matthew Giannelli (deleted user)	Author	58m	1	Yeah I think it would be good to have that discussion at ...
David Hannan (deleted user)	Reviewer - Complete	1m
Eliott Nicholson (deleted user)	Reviewer - Complete	30m	2	At some point in time we should have some discussion arou...
Total		1h 30m	3

Linked Issue:
PUL-6930

#permalink

Objectives

PUL-6930 Reworked aco_session_hierarchy updates, and refactored some
Merge branch 'develop' into feature/PUL-6930-aco-session-finalization-metrics-tracking
PUL-6930 Removed updateSiteHierarchy and updated unit tests

Also refactored some of the related DAO methods into smaller units of work, which are orchestrated in the service layer instead of DAO.

Tests executed locally:

Create Coils ACO session for site 4782 (first ACO session for this site)
> inserts new record into aco_site_hierarchy for site and coils hierarchy with status 1

Finalize Coils ACO session
> updates record in aco_site_hierarchy for site and coils hierarchy to status 2

Create Coils+Electric Pumps session for site 4782 (first ACO session for electric pumps, second for coils)
> inserts new record into aco_site_hierarchy for site and electric pumps hierarchy with status 1
> does not touch the existing record in aco_site_hierarchy for coils hierarchy

Finalize Coils+Electric Pumps ACO session
> updates record in aco_site_hierarchy for site and electric pumps hierarchy to status 2
> does not touch the existing record in aco_site_hierarchy for coils hierarchy

Delete ACO session
> records in aco_site_hierarchy are deleted for site and hierarchy id(s)

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

PUL-346

[PUL-6930] Reworked aco_session_hierarchy updates

PUL-346 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Create issue

Log time against

[PUL-6930] Reworked aco_session_hierarchy updates

PUL-346 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Create issue

Log time against