This is a list of all comments for ESB-112.

Review Summary: No summary


----------------------------------------
File: branches/APG_ES_Product/Java/nsight-product-availability/src/main/java/com/genpt/nsight/v4/AvailabilityServiceContextV4.java
Revision Comment by Tracy Martin on 28 February 2022, 15:09 
http://crucible.genpt.net/cru/ESB-112#c1217

  Best Practice: Use minimal access modifier needed. It would be
  private in this case since it is not called outside of this
  class.

Revision Comment by Tracy Martin on 28 February 2022, 15:08 
http://crucible.genpt.net/cru/ESB-112#c1216

  Should this be changed to expectationAfterCloseToday?

Revision Comment by Tracy Martin on 28 February 2022, 15:09 
http://crucible.genpt.net/cru/ESB-112#c1218

  It does not appear that this will be used because we only use
  these variables when useOffsets is false.

Revision Comment by Tracy Martin on 28 February 2022, 15:10 
http://crucible.genpt.net/cru/ESB-112#c1219

  I believe that min and max should be set to the same thing.  If
  so, we only need 1 if statement, and one call to the calculate
  method.

Revision Comment by Tracy Martin on 28 February 2022, 15:11 
http://crucible.genpt.net/cru/ESB-112#c1220

  I believe that min and max should be set to the same thing. If
  so, we only need 1 if statement, and one call to the calculate
  method.


---

ID: ESB-112 http://crucible.genpt.net/cru/ESB-112

Title: ESB-28680: [INVENTORY] On Demand Delivery Expectations Falling outside Store Business Hours
Statement of Objectives:
Delivery Expectations for On Demand Delivery is falling outside of store business hours.

State: Review

Author: Robin Mathew
Moderator: Rebekah Beary
Reviewers: (1 active, 0 completed*)
     Tracy Martin