ACT-2 NAC Build Automation

open for 10 years due 9 years ago

NAC Build Automation

Author

Moderator

Reviewers

Details
Objectives
General Comments 1
Number of files included: 3

Attachments 0
- File NAC_Build_Automation_configOutput.txt 2 Remove
- File NACconfigOutput.txt 28 Remove
- File configOutput_10292014.txt 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Manyu Kelsch	Author	1h 17m	15	Done
Amanda Bentley (deleted user)	Moderator
Joe McCord	Reviewer - Complete	1h 9m	16	This section of code is not really failing the Jenkins jo...
Total		2h 25m	31

#permalink

Objectives

Code Review

Project Info:

Job Location: http://auapgpdcibapp01/jenkins/view/Release%20Candidate%20Jobs/job/RC_NAPAAutoCare/
Requirements and Design: http://apgwiki.genpt.net/Configuration_Management/2014_Projects/AutoCare_Build_Automation_-_MQK
Automation Job Procedure: http://apgwiki.genpt.net/Configuration_Management/Procedures/Build_Procedures/Build_-_NAPA_Auto_Care

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Joe McCord

Amanda has established a new standard with the job parameters for the SVN log...

Amanda has established a new standard with the job parameters for the SVN login credentials. The SVNUSER and SVNPASS parameter names need to now be LDAP_USER_ID and LDAP_USER_PASSWD.

You need to incorporate error handling into the job:

validate job parameters are set correctly
validate code exists at the set path (look for solution file) before building
validate all necessary files were deleted as desired
before moving any files, validate the files exists at the expected location
after moving files, validate the files got moved to the new location
validate a tag was created if the option was selected
validate the build commit was successful

Make sure that each error handling check is logged

Send an email on success of job. One possible way is to add a post-build action titled 'Editable Email Notification' and add a trigger to that for 'Success'. This is purely a suggestion of a possible way. I have not tested this option myself.

23 Jun 14

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

ACT-2

NAC Build Automation

ACT-2 31

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Joe McCord

Create issue

Log time against

NAC Build Automation

ACT-2 31

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Joe McCord

Create issue

Log time against