Checkout Tools
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ESB-27909: [JAVA] Change all Java Services to use Spring Actuator for the health check
ESB-27909: [JAVA] Change all Java Services to use Spring Actuator for the health check
  • More
  • ESB-103
  • summarized and closed
should be esbuat1.genpt.net

should be esbuat1.genpt.net

should be esb2.genpt.net

should be esb2.genpt.net

Should be esb1.genpt.net

Should be esb1.genpt.net

ESB-27506: [JAVA] Migrate startup properties from startup scripts to YAML files - nsight-product availability/b2b
ESB-27506: [JAVA] Migrate startup properties from startup scripts to YAML files - nsight-product availability/b2b
  • More
  • ESB-24
  • finished reviewing
it is confusing to have a variable named V2 that is actually the V3 class .

it is confusing to have a variable named V2 that is actually the V3 class .

This is a good candidate for an Enum. It could go in the model package.

This is a good candidate for an Enum. It could go in the model package.

This is a good candidate for an Enum. It could go in the model package.

This is a good candidate for an Enum. It could go in the model package.

It would be more efficient to have 1 filter statement and 1 collect. For instance, .filter(s -> s.getDeliveryServiceType().compareToIgnoreCase(deliveryServiceType) == 0 && s.getDayOfTheWeek().compa...

It would be more efficient to have 1 filter statement and 1 collect. For instance,
.filter(s -> s.getDeliveryServiceType().compareToIgnoreCase(deliveryServiceType) == 0
&& s.getDayOfTheWeek().compareToIgnoreCase(dayOfWeek) == 0)
.collect(Collectors.toList());

Can we rename the name of the table to site_delivery_lead_time? Usually, table names are not plural. Could we change the order of the clustering key to delivery_service_type, day_of_week, reason_co...

Can we rename the name of the table to site_delivery_lead_time? Usually, table names are not plural.
Could we change the order of the clustering key to delivery_service_type, day_of_week, reason_code? I think this will be used more than the other way around during triage.

In this class we are still using v1 SplunkLogger.

In this class we are still using v1 SplunkLogger.

I see in some classes that we are still using v2 SplunkLogger, but in other classes, we are using v3.SplunkLogger. Do we need to have a v3? What's the difference?

I see in some classes that we are still using v2 SplunkLogger, but in other classes, we are using v3.SplunkLogger. Do we need to have a v3? What's the difference?

We should log the error if there is an exception with the stack trace.

We should log the error if there is an exception with the stack trace.

It is confusing to have the variable name as v2 and the class as v3.

It is confusing to have the variable name as v2 and the class as v3.

It is confusing to have the variable name as v2 and the class as v3.

It is confusing to have the variable name as v2 and the class as v3.

Should this be ProductAvailabilityControllerV3?

Should this be ProductAvailabilityControllerV3?

Should this be ProductAvailabilityControllerV3?

Should this be ProductAvailabilityControllerV3?

ESB-17639: [NSIGHT] Get Parts Changes to incorporate Lead Time Data
ESB-17639: [NSIGHT] Get Parts Changes to incorporate Lead Time Data
  • More
  • ESB-18
  • finished reviewing
ESB-16054: [NSIGHT] Store IP Change should trigger Store IP Cache Refresh for Get Parts
ESB-16054: [NSIGHT] Store IP Change should trigger Store IP Cache Refresh for Get Parts
  • More
  • ESB-9
  • finished reviewing
  • More
  • ESB-9
  • started review
ESB-14715: CLONE - DEV & UT - JavaSpringBoot
ESB-14715: CLONE - DEV & UT - JavaSpringBoot
Since we are using a logger, it would be best to log these using the logger so that these are written to the log file.

Since we are using a logger, it would be best to log these using the logger so that these are written to the log file.

What will happen if we receive an HttpStatus other than 200?

What will happen if we receive an HttpStatus other than 200?